[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 9 05:30:26 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a small nit.



================
Comment at: unittests/Lex/PPCallbacksTest.cpp:53
+    this->Imported = Imported;
+    this->FileType = FileType;
   }
----------------
Can you add a test that uses this field and checks its has the expected value?


https://reviews.llvm.org/D46614





More information about the cfe-commits mailing list