[PATCH] D46472: [HIP] Support offloading by linkscript
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 7 08:58:01 PDT 2018
yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: lib/CodeGen/CGCUDANV.cpp:317
+ if (GpuBinaryFileName.empty() && !IsHIP)
return nullptr;
----------------
rjmccall wrote:
> Is this filename string only used for CUDA? If so, please rename it to make that clear, or at least add a comment.
Yes. Will do.
https://reviews.llvm.org/D46472
More information about the cfe-commits
mailing list