[PATCH] D46504: [clang-tidy] Profile is a per-AST (per-TU) data.
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 7 00:27:19 PDT 2018
lebedev.ri added inline comments.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181
std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider)
- : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
- Profile(nullptr) {
+ : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)) {
// Before the first translation unit we can get errors related to command-line
----------------
Eugene.Zelenko wrote:
> Will be good idea to use default member initialization for DiagEngine too.
Yes, but in the context of the diff that would be a completely unrelated change, i try to avoid those..
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46504
More information about the cfe-commits
mailing list