[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

[Nikolai Kosjar via Phabricator via cfe-commits]

nik marked an inline comment as done.
nik added inline comments.


================
Comment at: test/Frontend/plugins.c:8
+// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS  %s
+// REQUIRES: plugins, examples
+
----------------
thakis wrote:
> nik wrote:
> > Note that I actually have problems with this REQUIRES line. I use -DCLANG_BUILD_EXAMPLES and -DDBUILD_SHARED_LIBS=ON and this test (and the one above too) is skipped/unsupported. What else do I need?
> > 
> > Note that If I remove this line, the test is run - apparently the requirements are fulfilled, but not properly detected. I guess this is set up issue on my local machine?
> Are you on Windows? plugins is set here: http://llvm-cs.pcc.me.uk/tools/clang/test/lit.cfg.py#73
> enable_shared here: http://llvm-cs.pcc.me.uk/tools/clang/test/lit.site.cfg.py.in#25
> from here: http://llvm-cs.pcc.me.uk/cmake/modules/AddLLVM.cmake#1193
> 
> So my guess is you need to set LLVM_ENABLE_PLUGINS (and that you are on Windows), but I haven't tried it.
No, I'm not on Windows. Adding some debug-prints to the python scripts it looks like the "examples" thingy is actually not  fulfilled here. Anyway, that's something for another change (will upload a separate change for this)


https://reviews.llvm.org/D46050