[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 4 05:42:48 PDT 2018


aaron.ballman added a comment.

This approach generally looks good to me, but I'd like @rsmith's opinion on whether we should be trying to make -ast-print have good source fidelity or not. I was under the impression we wanted -ast-print to faithfully reproduce code at least as a low priority desire, but it sounds like it may only be intended as an approximation of the user's source code, so adding extra machinery to support better fidelity may be more maintenance burden than it's worth.


https://reviews.llvm.org/D45093





More information about the cfe-commits mailing list