[PATCH] D33537: [clang-tidy] Exception Escape Checker

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.


================
Comment at: docs/clang-tidy/checks/bugprone-exception-escape.rst:8-9
+* Destructors
+* Copy constructors
+* Copy assignment operators
+* The ``main()`` functions
----------------
dberris wrote:
> Are copy constructors and assignment operators not supposed to throw? Or did you mean *move* constructors?
You are right. In the description below it is correct, but here there was a typo.


================
Comment at: docs/clang-tidy/checks/bugprone-exception-escape.rst:28
+
+   Comma separated list containing function names which should not throw. An
+   example for using this parameter is the function ``WinMain()`` in the
----------------
dberris wrote:
> `EnabledFunctions` but they *should not* throw?
Maybe we should come up with a better name for this option. I just took this from our company internal check.


https://reviews.llvm.org/D33537