[PATCH] D40937: [clang-tidy] Infinite loop checker

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 3 09:08:07 PDT 2018


alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tidy/bugprone/InfiniteLoopCheck.h:37
+private:
+  bool updateSequence(Stmt *FunctionBody, ASTContext &ASTCtx);
+  const Stmt *PrevFunctionBody;
----------------
Why bool? The return value is not used anywhere.


================
Comment at: docs/ReleaseNotes.rst:68
+- New :doc:`bugprone-infinite-loop
+  <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-infinite-loop.html>` check
+
----------------
There should be a trailing period in each of these `New ... check` items. I've updated the script in r331460 and the existing release notes in r331461. Please rebase.


https://reviews.llvm.org/D40937





More information about the cfe-commits mailing list