[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 3 07:40:15 PDT 2018
a.sidorin added a comment.
Hello Peter! This looks almost OK, just some minor formatting issues.
================
Comment at: unittests/AST/ASTImporterTest.cpp:1509
+ MatchVerifier<Decl> Verifier;
+ testImport("template <typename T> struct S {static T foo;};"
+ "template <typename T> void declToImport() {"
----------------
Please add spaces after and before `{}`.
================
Comment at: unittests/AST/ASTImporterTest.cpp:1510
+ testImport("template <typename T> struct S {static T foo;};"
+ "template <typename T> void declToImport() {"
+ " (void) S<T>::foo;"
----------------
Indentation is a bit off here and in the samples below.
https://reviews.llvm.org/D38845
More information about the cfe-commits
mailing list