[PATCH] D43750: Allow writing calling convention attributes on function types

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 2 15:14:19 PDT 2018


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

I'm really sad about this; C++11 attributes were supposed to fix the undisciplined "do what I mean" behavior of GNU attributes. But you're right, these really are type attributes, and really should be permitted to appertain to types. That we permit these to appertain to function declarations is the mistake, but it's a mistake we need to make to match GCC, so while I'm sad about it, I think this patch is the right thing.


https://reviews.llvm.org/D43750





More information about the cfe-commits mailing list