[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 2 14:00:58 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D46159#1085684, @dcoughlin wrote:

> In https://reviews.llvm.org/D46159#1085548, @pfultz2 wrote:
>
> > > Do you have some better choices?
> >
> > I could do `-allow-alpha-checks`. What do you think?
>
>
> That seems reasonable to me.




> Although I like `-allow-enabling-alpha-checks` better because it is longer and will therefore discourage its use.

This sounds good to me too. Conveys the idea that it only *allows* to enable them, not actually enables them.

> Do you think it would be possible to have a mechanism that prevents people from turning on all alpha checks at once? That is what I'm worried about. People enabling individual alpha checks to test them out is fine, but people enabling all of them is not a good experience.

While in this particular case it may make sense, it also may open the road for restricting/removing `-checks=*` support, which would be **quite** unfortunate :/


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46159





More information about the cfe-commits mailing list