[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 2 08:49:00 PDT 2018
Anastasia added a comment.
In https://reviews.llvm.org/D46049#1081196, @yaxunl wrote:
> Can you add a codegen test for 1.2, 2.0?
Anything specific you would like me to check? I am not modifying anything in CodeGen here though.
> Also, I am wondering whether this is valid for OpenCL C++. Do we need special handling for string literal?
Actually OpenCL C++ makes no statement about string literal. But I think we will want it to be in constant AS. I will raise it with Khronos.
https://reviews.llvm.org/D46049
More information about the cfe-commits
mailing list