[PATCH] D46190: For an ODR declaration, set the 'Used' bit on its associated declarations.

[Carlos Alberto Enciso via Phabricator via cfe-commits]

CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D46190#1081836, @rsmith wrote:

> In https://reviews.llvm.org/D46190#1081773, @rsmith wrote:
>
> > No, absolutely not. This would be insanely expensive, and marks entirely unrelated things "used".
>
>
> My apologies, reading this again it comes off a lot harsher than I'd intended.


I appreciate your apology and I understand your concerns. I do not have much knowledge on this area.

My initial intention was to traverse just the associated type for an odr-used declaration and mark them as used, as an indication that those types are "really needed" for that odr-declaration.  The type chain is traversed just once.

The approach was intended as a general solution, not only for the original 'using declaration' issue.

I will have a look at your suggested approach.

Thanks very much for your feedback.


Repository:
  rC Clang

https://reviews.llvm.org/D46190