[PATCH] D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 27 16:17:04 PDT 2018


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Serialization/ASTReaderDecl.cpp:2568-2570
   // ODR-based merging is only performed in C++. In C, identically-named things
   // in different translation units are not redeclarations (but may still have
+  // compatible types). However, clang is able to merge tag types with ODR-like
----------------
I think this comment would benefit from more rewriting, since we've basically decided that we do want to apply the ODR merging rule to C.


Repository:
  rC Clang

https://reviews.llvm.org/D46165





More information about the cfe-commits mailing list