[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D46159#1081392, @dcoughlin wrote:

> In https://reviews.llvm.org/D46159#1081371, @lebedev.ri wrote:
>
> > Note that it is completely off by default, and is not listed in documentation, `clang-tidy --help`,
> >  so one would have to know of the existence of that hidden flag first, and only then when that flag is passed, those alpha checks could be enabled.
>
>
> All it takes is one stack overflow comment or blog post recommending the flag and then we're back where we started. I'm really worried about well-intentioned ("running more checks means higher-quality code, so let's run ALL the checks") people enabling this option and having a bad experience.
>
> Can you explain what the benefit of this flag is? How do you envision it being used?


What about `scan-build` proper?
Those alpha checks are always present in all builds, one always can pass `-enable-checker alpha.clone.CloneChecker`.
I would understand if there was a cmake-time switch to build those, but there isn't one..

Also, it is *much* easier to use `clang-tidy` rather than clang-analyzer, because you can run clang-tidy on an existing compilation database,
while in `scan-build`'s case, you need whole new build. It's cumbersome.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46159