[PATCH] D46115: [ASTImporter] properly import SrcLoc of Attr

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin added a comment.

Hi all. I'm already here, invited by the Herald - just had no time to take a look (will change the script to add me as a reviewer). But thank you anyway! :)

In the initial implementation (https://raw.githubusercontent.com/haoNoQ/clang/summary-ipa-draft/lib/AST/ASTImporter.cpp), we already had this feature, and it was even called similarly - `ImportAttributes()`. But the centralized  import inside `Imported` (or even `Import()?), as it is done in this patch, looks to be a better option to me.
I'm not sure that we have to "merge" attributes. Moreover, declarations with different attributes can be considered structurally different (possibly, in an another patch). But I can possibly be missing something so feel free to correct me.


Repository:
  rC Clang

https://reviews.llvm.org/D46115