[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

[Aleksandar Beserminji via Phabricator via cfe-commits]

abeserminji added inline comments.


================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340
+  "ignoring '%0' option as it cannot be used with "
+  "explicit use of -mabicalls and the N64 ABI">,
   InGroup<OptionIgnored>;
----------------
sdardis wrote:
> Use the %select{optionA|optionB|..|optionZ}$NUM operator here like:
> 
> "cannot be used with the %select{explicit|implicit}1 usage of -mabicalls and the N64 ABI"
> 
> Which eliminates the need for two separate warnings.
Thanks for the hint. I simplified it now.


https://reviews.llvm.org/D44684