[PATCH] D45814: Fix an assertion when -print-prog-name=
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 26 17:52:38 PDT 2018
compnerd added a comment.
I'm torn on this. The other `-print` options will perform the validation implicitly at the higher level before calling the inner functions. It is certainly reasonable to support that, but, for the common path, this check seems unnecessary (and this function is used elsewhere in clang). There is a similar problem that exists with `-print-file-name=`. We should probably fix both at the same time. Can you also please add a test case for this?
Repository:
rC Clang
https://reviews.llvm.org/D45814
More information about the cfe-commits
mailing list