[PATCH] D46115: [ASTImporter] properly import SrcLoc of Attr
Rafael Stahl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 26 05:16:03 PDT 2018
r.stahl added a comment.
This is unfinished. Posting to make you aware of the issue. There are other occurances of imported attrs without importing the srcloc in:
- VisitIndirectFieldDecl
- VisitAttributedStmt
So I was thinking this would suggest to add a public API `ASTImporter::Import(Attr *)`. Does it make sense to add this? Is there anything else I need to do to change public API?
Merging of Attr would also be missing and I wouldn't know how to approach this.
Testing also added soon!
Repository:
rC Clang
https://reviews.llvm.org/D46115
More information about the cfe-commits
mailing list