[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

[Nikolai Kosjar via Phabricator via cfe-commits]

nik added a comment.

In https://reviews.llvm.org/D46050#1078112, @thakis wrote:

> Seems reasonable; can you add a test for this (maybe somewhere in clang/test/Frontend/plugin*)?


Done.

In https://reviews.llvm.org/D46050#1078155, @john.brawn wrote:

> I know very little about how code completion works, but it's not immediately obvious to me that disabling plugin ast consumers when code completion is enabled is necessarily correct. In what kind of scenario would we both have a plugin loaded that wants to insert an ast consumer before/after the main one, and also be doing code completion?


For example if you use libclang with the clang tidy plugin. I've put this into the commit message.


Repository:
  rC Clang

https://reviews.llvm.org/D46050