[PATCH] D45964: [Driver] Fix implicit config files from prefixed symlinks

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 25 11:38:07 PDT 2018


sepavloff added a comment.

In https://reviews.llvm.org/D45964#1077217, @mstorsjo wrote:

> Added an isEmpty() method.


This variant is more readable.

> Btw, did you see https://bugs.llvm.org/show_bug.cgi?id=37196? That one feels quite a bit more convolved so I don't really know (so far) how to approach fixing that.

Indeed, that bug looked mysterious. The reason is that `InputArgList` assumes its field `ArgStrings` contains strings for each argument exactly in the same order, this condition was broken when arguments from config file and from invocation were merged. I will commit the patch soon.


https://reviews.llvm.org/D45964





More information about the cfe-commits mailing list