[PATCH] D46065: [clangd] Add "str()" method to SymbolID.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 25 08:30:42 PDT 2018
hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: clangd/index/Index.h:72
+ // Returns a 40-bytes hex encoded string.
+ std::string str() const;
----------------
ioeric wrote:
> I think Sam wants to reduce the size to 20 bytes. Maybe just drop the "40-bytes" part?
The comment clarifies the current behavior of the method, I prefer to keep it. We can change it at the time when we reduce the size :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46065
More information about the cfe-commits
mailing list