[PATCH] D46030: [TargetInfo] Sort target features before passing them to the backend

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 25 02:01:58 PDT 2018


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Eli, LGTM!



================
Comment at: lib/Basic/Targets.cpp:641
     Opts->Features.push_back((F.getValue() ? "+" : "-") + F.getKey().str());
+  llvm::sort(Opts->Features.begin(), Opts->Features.end());
 
----------------
Could you add a comment here briefly explaining why we sort here?


Repository:
  rC Clang

https://reviews.llvm.org/D46030





More information about the cfe-commits mailing list