[PATCH] D44882: [clangd] Implementation of workspace/symbol request

[Sam McCall via Phabricator via cfe-commits]

sammccall added a subscriber: bkramer.
sammccall added a comment.

In https://reviews.llvm.org/D44882#1076927, @malaperle wrote:

> In https://reviews.llvm.org/D44882#1076864, @sammccall wrote:
>
> > So this fails if there's no standard library available without flags, which is the case in google's test environment to ensure hermeticity :-(
> >
> > In the short-term, we've disabled the test internally - did it trigger any buildbot failures?
> >  In the medium term we should probably find a better way to test this :(
>
>
> No buildbot failures yet. But I suggest we just remove the test and add it back when we collect more symbols, i.e. in main files. WDYT?


It makes sense, but @bkramer came up with some deep magic in https://reviews.llvm.org/rL330754 so I think we're actually good now.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44882