[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

Alexey Sotkin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 24 15:33:33 PDT 2018


AlexeySotkin added inline comments.


================
Comment at: lib/CodeGen/CGOpenCLRuntime.h:65
   virtual llvm::Type *getPipeType(const PipeType *T);
+  virtual llvm::Type *getPipeType(const PipeType *T, StringRef Name,
+                                  llvm::Type *&PipeTy);
----------------
I'm not sure that it is a good idea to make this function public, as its parameter supposed to be a reference to protected member.


Repository:
  rC Clang

https://reviews.llvm.org/D46015





More information about the cfe-commits mailing list