[PATCH] D44882: [clangd] Implementation of workspace/symbol request

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In https://reviews.llvm.org/D44882#1066743, @malaperle wrote:

> In https://reviews.llvm.org/D44882#1065632, @sammccall wrote:
>
> > In https://reviews.llvm.org/D44882#1065631, @malaperle wrote:
> >
> > > In https://reviews.llvm.org/D44882#1065622, @sammccall wrote:
> > >
> > > > Still LG, thanks!
> > > >  I'll look into the testing issue.
> > >
> > >
> > > I thought about it after... I think it was because I was trying to test with std::unordered_map (to prevent multiple results) which needs std=c++11, I'll try with something else.
> >
> >
> > Worth a shot, but don't count on it - for c++ clang switched to using std=c++11 by default a while ago.
>
>
> I just tried "std::basic_ostringstream" and that works. Seems safer.


So this fails if there's no standard library available without flags, which is the case in google's test environment to ensure hermeticity :-(

In the short-term, we've disabled the test internally - did it trigger any buildbot failures?
In the medium term we should probably find a better way to test this :(


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44882