[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D45920#1074437, @george.karpenkov wrote:

> > I could also move RangedConstraintManager.h under include
>
> We probably don't want to do that: currently it can only be imported by files in `Core`, and we probably should keep it that way


I believe that many of our warning messages could be improved by presenting ranges to the user. Eg., `ArrayBoundChecker` could benefit from something like "index is within range [11, 12] and array size is equal to 10", and then a visitor that explains all the places in which the index was constrained to a smaller range. So in long term i'll be in favor of providing a way of explaining constraints to the users, which means partially exposing constraint manager internals to the checkers in a certain way (not necessarily *this* way). So for now i have no opinion on this issue :)


Repository:
  rC Clang

https://reviews.llvm.org/D45920