[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 23 12:03:47 PDT 2018


NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/RangedConstraintManager.h:130
+template <>
+struct ProgramStateTrait<ConstraintRange>
+  : public ProgramStatePartialTrait<ConstraintRangeTy> {
----------------
george.karpenkov wrote:
> Why not also `REGISTER_TRAIT_WITH_PROGRAMSTATE` here?
```
   33   /// The macro should not be used inside namespaces, or for traits that must
   34   /// be accessible from more than one translation unit.
   35   #define REGISTER_TRAIT_WITH_PROGRAMSTATE(Name, Type) \
   36   ...
```
I don't remember why.


Repository:
  rC Clang

https://reviews.llvm.org/D45920





More information about the cfe-commits mailing list