[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

Thomas Preud'homme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 23 09:28:52 PDT 2018


thopre added inline comments.


================
Comment at: lib/Basic/Targets/AArch64.h:85-89
+  StringRef getConstraintRegister(StringRef Constraint,
+                                  StringRef Expression) const override {
+    return Expression;
+  }
+
----------------
>From what I understood of the original patch, getConstraintRegister is a sort of a more comprehensive version of convertRegister. On ARM convertRegister handles U and p constraint specially, should this do the same?


https://reviews.llvm.org/D45965





More information about the cfe-commits mailing list