[PATCH] D45966: Remove LLVM_INSTALL_CCTOOLS_SYMLINKS

[Nico Weber via Phabricator via cfe-commits]

thakis created this revision.
thakis added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.

It used to symlink `dsymutil` to `llvm-dsymutil`, but after r327790 llvm's dsymutil binary is now called dsymutil without prefix.

r327792 then reversed the direction of the symlink if LLVM_INSTALL_CCTOOLS_SYMLINKS was set, but that looks like a buildfix and not like something anyone should need.


https://reviews.llvm.org/D45966

Files:
  CMakeLists.txt
  docs/CMake.rst
  tools/dsymutil/CMakeLists.txt


Index: tools/dsymutil/CMakeLists.txt
===================================================================
--- tools/dsymutil/CMakeLists.txt
+++ tools/dsymutil/CMakeLists.txt
@@ -25,8 +25,3 @@
 if(APPLE)
   target_link_libraries(dsymutil PRIVATE "-framework CoreFoundation")
 endif(APPLE)
-
-if(LLVM_INSTALL_CCTOOLS_SYMLINKS)
-  add_llvm_tool_symlink(llvm-dsymutil dsymutil)
-endif()
-
Index: docs/CMake.rst
===================================================================
--- docs/CMake.rst
+++ docs/CMake.rst
@@ -228,10 +228,6 @@
   Install symlinks from the binutils tool names to the corresponding LLVM tools.
   For example, ar will be symlinked to llvm-ar.
 
-**LLVM_INSTALL_CCTOOLS_SYMLINKS**:BOOL
-  Install symliks from the cctools tool names to the corresponding LLVM tools.
-  For example, dsymutil will be symlinked to llvm-dsymutil.
-
 **LLVM_BUILD_EXAMPLES**:BOOL
   Build LLVM examples. Defaults to OFF. Targets for building each example are
   generated in any case. See documentation for *LLVM_BUILD_TOOLS* above for more
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -194,9 +194,6 @@
 option(LLVM_INSTALL_BINUTILS_SYMLINKS
   "Install symlinks from the binutils tool names to the corresponding LLVM tools." OFF)
 
-option(LLVM_INSTALL_CCTOOLS_SYMLINKS
-  "Install symlinks from the cctools tool names to the corresponding LLVM tools." OFF)
-
 option(LLVM_INSTALL_UTILS "Include utility binaries in the 'install' target." OFF)
 
 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45966.143562.patch
Type: text/x-patch
Size: 1629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180423/a835f5d7/attachment.bin>