[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 22 18:54:15 PDT 2018
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: kbarton.
I don't think this is quite right. I know at least `make`-based incremental builds wouldn't deal well with this.
Given t.cpp:
#if __has_include("missing.h")
#endif
t.d will be:
t.o: missing.h
Since the build system doesn't know how to generate missing.h, when t.cpp changes the build system will stop dead in its tracks.
Knowing the list of files that are //potential// inputs to `t.o` seems useful, but we should probably do that under a separate flag. And if it's a separate flag, we might consider giving it a better name than `-MF`...
https://reviews.llvm.org/D30882
More information about the cfe-commits
mailing list