[PATCH] D45505: [WIP] [GCC] Match a GCC version with a patch suffix without a third version component

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 22 15:12:53 PDT 2018


chandlerc added a comment.

In https://reviews.llvm.org/D45505#1074747, @mstorsjo wrote:

> In https://reviews.llvm.org/D45505#1074744, @chandlerc wrote:
>
> > Definitely need tests here.
>
>
> Do you have any suggestion on where to create them and what kind? Just a normal test with a fake directory tree, or some sort of unit test for the gcc version number matching logic? (And if creating a unit test, how does that work since this class isn't in the public include directory?)


All of this logic is tested with fake directories trees and tests in test/Driver.

Should be able to look at other commits in this space to see examples of test?


Repository:
  rC Clang

https://reviews.llvm.org/D45505





More information about the cfe-commits mailing list