[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:2342
+  if (isa<AutoType>(Ty))
+    return false;
   return true;
----------------
rjmccall wrote:
> rjmccall wrote:
> > I agree with your analysis that this shouldn't be a substitution candidate.  However, I think this probably needs an ABI-compatibility guard.
> You should probably add a comment like "Prior to LLVM v6, Clang accidentally treated deduced auto types as substitution candidates."
Er, not "prior to", I guess.  "through", maybe, or "up to and including".


https://reviews.llvm.org/D45451