[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

A few style-related comments.



================
Comment at: docs/clang-tidy/index.rst:677
+To check more than one scenario in the same test file use 
+``-check-suffix=SUFFIX_NAME`` on ``check_clang_tidy.py`` command line.
+With ``-check-suffix=SUFFIX_NAME`` you need to replace your ``CHECK-*`` 
----------------
s/SUFFIX_NAME/SUFFIX-NAME/

Same below.


================
Comment at: docs/clang-tidy/index.rst:685
+
+   // RUN: %check_clang_tidy -check-suffix USING-A %s misc-unused-using-decls %t -- -- -DUSING_A
+   // RUN: %check_clang_tidy -check-suffix USING-B %s misc-unused-using-decls %t -- -- -DUSING_B
----------------
I'd use the ``-check-suffix=...`` format (with the equals sign) for consistency with the documentation.


================
Comment at: test/clang-tidy/check_clang_tidy.py:21
     [-assume-filename <file-with-source-extension>] \
+    [-check-suffix <FileCheck suffix>] \
     <source-file> <check-name> <temp-file> \
----------------
``-check-suffix=<file-check-suffix>`` and maybe the same for -assume-filename


https://reviews.llvm.org/D45776