[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Checked this out, seems to be safely ignored for now. The `.plist` format is pretty resistant to this sort of stuff because most APIs to handle it are almost treating it as native arrays/dictionaries, so i guess it should be fine.

In https://reviews.llvm.org/D45407#1068724, @whisperity wrote:

> @NoQ The problem with emitting notes as events is that we lose the information that the node was a `note`. How does Xcode behave with these notes? Does it ignore them, or can read them from the command-line output of the analyser?


Yep, precisely: notes are completely different from path pieces - they shouldn't be connected to the rest of the path via arrows or necessarily have a certain ordering with respect to the path.

For now notes are ignored by Xcode; there's no good UI for them implemented. They are also not used by many on-by-default checkers, so they're mostly an experiment for now.


Repository:
  rC Clang

https://reviews.llvm.org/D45407