[PATCH] D45897: Convert clang-interpreter to ORC JIT API
Alexander Shaposhnikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 20 13:09:17 PDT 2018
alexshap added inline comments.
================
Comment at: examples/clang-interpreter/main.cpp:52
+class SimpleJIT {
+private:
+ ExecutionSession ES;
----------------
not needed
================
Comment at: examples/clang-interpreter/main.cpp:84
+
+ TargetMachine &getTargetMachine() { return *TM; }
----------------
const TargetMachine & ?
================
Comment at: examples/clang-interpreter/main.cpp:93
+
+ JITSymbol findSymbol(const std::string Name) {
+ std::string MangledName;
----------------
const string & or maybe even StringRef and the same below
Repository:
rC Clang
https://reviews.llvm.org/D45897
More information about the cfe-commits
mailing list