[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

[Simeon Ehrig via Phabricator via cfe-commits]

SimeonEhrig added inline comments.


================
Comment at: lib/CodeGen/CGCUDANV.cpp:287
+    CtorSuffix.append("_");
+    CtorSuffix.append(ModuleName);
+  }
----------------
tra wrote:
> There is a general problem with this approach. File name can contain the characters that PTX does not allow.
> We currently only deal with '.' and '@', but that's not enough here.
> You may want to either mangle the name somehow to avoid/convert illegal characters or use some other way to provide unique suffix. Hex-encoded hash of the file name would avoid this problem, for example.
> 
> 
> 
Maybe I'm wrong but I think, that should be no problem, because the generating of a cuda ctor/dtor have nothing to do with the PTX generation. 

The function 'makeModuleCtorFunction' should just generate llvm ir code for the host (e.g. x86_64).

If I'm wrong, could you tell me please, where in the source code the 'makeModuleCtorFunction' affect the PTX generation.


https://reviews.llvm.org/D44435