[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 20 01:05:33 PDT 2018
klimek added inline comments.
================
Comment at: lib/Format/WhitespaceManager.cpp:438
+
+ AlignTokens(Style,
+ [&](const Change &C) {
----------------
I'm not sure whether we should use AlignTokens here, given that we pass in a parameter to basically skip all its interesting logic.
What I'd personally do is try to implement the alignment of macros on their own merit from scratch, which should be significantly simpler, and then look for whether we can pull out common functions between AlignTokens and that implementation to further reduce duplication.
Repository:
rL LLVM
https://reviews.llvm.org/D28462
More information about the cfe-commits
mailing list