[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

[Shuai Wang via Phabricator via cfe-commits]

shuaiwang updated this revision to Diff 143197.
shuaiwang marked 13 inline comments as done.
shuaiwang added a comment.

- Moved out of ASTUtils and becomes a separte class ExprMutationAnalyzer (bikeshedding on name a bit.)
- Reverted back to return bool instead of tri-valued enum, the meanings of Escaped and Modified are not well defined.
- Cosmetic changes like spliting large function and reducing duplicates.
- Addressed comments.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45679

Files:
  clang-tidy/utils/CMakeLists.txt
  clang-tidy/utils/ExprMutationAnalyzer.cpp
  clang-tidy/utils/ExprMutationAnalyzer.h
  unittests/clang-tidy/CMakeLists.txt
  unittests/clang-tidy/ExprMutationAnalyzerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45679.143197.patch
Type: text/x-patch
Size: 33213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180420/fe021292/attachment-0001.bin>