[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

I've pushed this further - it builds now & has no fallback in libBasic to the old behavior/table.

One remaining thing I'm unsure about is the table of DIAG_START_* values. Do you think this is OK/good to leave hardcoded in diagnostics? Should I somehow remove the need for that global knowledge (dynamically allocating the start ranges of each grouping?)? Or go the other way & decide this global information renders this direction questionable and just sink all the diagnostics into Basic explicitly/properly?


Repository:
  rC Clang

https://reviews.llvm.org/D41357