[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: lib/CodeGen/CGCUDANV.cpp:287
+    CtorSuffix.append("_");
+    CtorSuffix.append(ModuleName);
+  }
----------------
There is a general problem with this approach. File name can contain the characters that PTX does not allow.
We currently only deal with '.' and '@', but that's not enough here.
You may want to either mangle the name somehow to avoid/convert illegal characters or use some other way to provide unique suffix. Hex-encoded hash of the file name would avoid this problem, for example.





https://reviews.llvm.org/D44435