[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 19 06:20:30 PDT 2018


erichkeane added a comment.

Can you make sure that this doesn't cause stackrealign to happen 2x if using -mstackrealign?  Additionally, please provide the diff with full-context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).  What is the commit before this?  The line numbers don't look right to me.

Barring any surprises from those two, this looks alright to me.


Repository:
  rC Clang

https://reviews.llvm.org/D45812





More information about the cfe-commits mailing list