[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

Thu Apr 19 05:54:04 PDT 2018

sammccall added a comment.

In https://reviews.llvm.org/D45478#1071983, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D45478#1064027, @sammccall wrote:
>
> > Is this patch still relevant after haojian's string deduplication?
>
>
> Apparently it does. It has an advantage of distributing the work more evenly between the program runs.
>  Currently the tool reports progress based on the number of files it parsed. But then it takes a lot of time to actually merge all the symbols at the end and the progress is not reported during that time.
>
> The perfect behavior would be to remove duplicates, not just intern them :-) That shouldn't be too hard and it probably even makes sense to have a ToolExecutor that does that.

OK, can we sync up offline with @hokein and decide what to do here? I don't think it makes sense to have both these solutions to the same issue, but I don't have a strong opinion on exactly what we do.
(Other than clearly the right solution is to have a proper MR framework <half-trolling>)

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45478