[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

Thank you for the contribution!
Please update the documentation accordingly (http://clang.llvm.org/extra/clang-tidy/#testing-checks).

> // RUN: %check_clang_tidy %s misc-unused-using-decls %t -check_suffix=-FLAG_1--  <option set 1>

I don't know whether it makes sense to endorse (or even allow) the use of underscore in the check suffix. The mix of underscores and dashes looks ugly and is prone to errors.



================
Comment at: test/clang-tidy/check_clang_tidy.cpp:16
+// CHECK-FIXES-NOT: using a::B;$
\ No newline at end of file

----------------
Fix "No newline at end of file"


================
Comment at: test/clang-tidy/check_clang_tidy.py:45
   parser.add_argument('-assume-filename')
+  parser.add_argument('-check_suffix', default='')
   parser.add_argument('input_file_name')
----------------
Please use dash as a separator as in other arguments.


================
Comment at: test/clang-tidy/check_clang_tidy.py:77
+
+  check_fixes_prefix = 'CHECK-FIXES' + args.check_suffix
+  check_messages_prefix = 'CHECK-MESSAGES' + args.check_suffix
----------------
Maybe the script should add a dash when check_suffix is not empty, so that one could use -check-suffix=FLAG instead of -check-suffix=-FLAG?


================
Comment at: test/clang-tidy/check_clang_tidy.py:102
+
+  print "\n\n\n---->>>",input_text, "<<-----\n\n"
 
----------------
Looks like debug output. Remove?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45776