[PATCH] D45750: add extra acronyms for objc property names

Yan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 18 13:05:17 PDT 2018


Wizard added inline comments.


================
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:42
 constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
+    "[2-9]G",
     "ACL",
----------------
benhamilton wrote:
> Probably should just make this:
> 
>   "\\d+G"
> 
It seems llvm::Regex does not recognize \d somehow. I tried \\d+ does not work for the test. Will keep [2-9]G for now.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45750





More information about the cfe-commits mailing list