[PATCH] D44984: [HIP] Add hip input kind and codegen for kernel launching

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 4 inline comments as done.
yaxunl added inline comments.


================
Comment at: lib/Frontend/InitPreprocessor.cpp:466-467
     Builder.defineMacro("__ASSEMBLER__");
   if (LangOpts.CUDA)
     Builder.defineMacro("__CUDA__");
+  if (LangOpts.HIP)
----------------
tra wrote:
> Is `__CUDA__` supposed to be set during HIP compilation?  My guess is that `__HIP__` and `__CUDA__` should be mutually exclusive. 
> You do set LangOpts.CUDA during HIP compilation, so this should be changed to `if (CUDA && ! HIP)`
HIP documentation does not require `__CUDA__` to be defined. Will make changes as you suggested.


https://reviews.llvm.org/D44984