[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name
Simeon Ehrig via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 18 06:14:43 PDT 2018
SimeonEhrig marked 2 inline comments as done.
SimeonEhrig added inline comments.
================
Comment at: lib/CodeGen/CGCUDANV.cpp:358
+ if (ModuleName.empty())
+ ModuleName = "<null>";
+
----------------
rjmccall wrote:
> This doesn't actually seem more useful than the empty string.
We improved the implementation. If there is no module name, it will not append any suffix and the symbol is just '__cuda_module_ctor'.
https://reviews.llvm.org/D44435
More information about the cfe-commits
mailing list