[PATCH] D45702: [clang-tidy] Add a new check, readability-redundant-data-call, that finds and removes redundant calls to .data().

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 17 11:50:04 PDT 2018


aaron.ballman added a comment.

Have you run this over any large code bases to see whether the check triggers in practice?



================
Comment at: docs/clang-tidy/checks/list.rst:95
    fuchsia-default-arguments
+   fuchsia-header-anon-namespaces (redirects to google-build-namespaces) <fuchsia-header-anon-namespaces>
    fuchsia-multiple-inheritance
----------------
This change looks unrelated to the patch and should be handled separately.


================
Comment at: docs/clang-tidy/checks/readability-redundant-data-call.rst:6
+
+This check suggests removing redundant `.data()` calls.
+
----------------
What does it mean for a `data()` call to be redundant? I think the documentation needs to explain that a bit more.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45702





More information about the cfe-commits mailing list