[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

Mikhail Ramalho via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 17 03:12:28 PDT 2018


mikhail.ramalho added a comment.

Sure. Basically, the previous code would not generate the USR for the function's parameters.

The issue was that SM.getFileEntryForID would return NULL because there is no actual file, that's why I changed to get the presumedLoc and build the name using the column/line.

I know that using column/line not the preferable method to generate USR but I couldn't find a way to generate the offset of a presumed location.


Repository:
  rC Clang

https://reviews.llvm.org/D42966





More information about the cfe-commits mailing list