[PATCH] D45716: [XRay] Add clang builtin for xray typed events.
Dean Michael Berris via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 16 23:39:26 PDT 2018
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D45716#1069567, @dberris wrote:
> In https://reviews.llvm.org/D45716#1069557, @kpw wrote:
>
> > My editor got a bit carried away with automatically clang-formatting lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the revision history.
>
>
> Yes please. :)
>
> Also, if you can add to the tests for instrumentation bundles in `test/Driver/XRay/...` to ensure that we're properly not seeing the typed events there either, that would be great.
Actually, I see that change too. Ignore that. :)
LGTM (pending the revert of formatting changes in `lib/CodeGen/CodeGenFunction.cpp`).
Repository:
rC Clang
https://reviews.llvm.org/D45716
More information about the cfe-commits
mailing list