[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

[Keith via Phabricator via cfe-commits]

kpw added inline comments.


================
Comment at: test/CodeGen/xray-typedevent.cpp:10
+  __xray_typedevent(EventType, kPhase, 10);
+  // CHECK: call void @llvm.xray.typedevent(i16 {{.*}}, i8*{{.*}}, i32 10)
+}
----------------
FYI: It would be involved to match on more than * for the event type because the actual IR does things like unsigned extension and truncation to i16. The IR looked sane to me though. It's a shame the BuiltIns.def type attributes are defined in terms like short, half, and size_t rather than fixed width types. /shrug


Repository:
  rC Clang

https://reviews.llvm.org/D45716